Skip to content

Align error message of _pyio.TextIOWrapper.seek with its C implementation #128852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Align error message of _pyio.TextIOWrapper.seek with its C implementation #128852

wants to merge 9 commits into from

Conversation

@DimmaDont
Copy link

fix error message on seek of closed TextIOWrapper file in the python implementation of the io module

@ghost
Copy link

ghost commented Jan 15, 2025 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jan 15, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

lazysegtree
lazysegtree approved these changes Jan 15, 2025
View reviewed changes
Copy link

@lazysegtree lazysegtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks @DimmaDont for finding this.

@picnixz
Copy link
Member

picnixz commented Jan 15, 2025

Can you confirm that this aligns with the C implementation of TextIOWrapper please?

@picnixz picnixz changed the title fix error message Align error message of _pyio.TextIOWrapper.seek with its C implementation Jan 15, 2025
@DimmaDont
Copy link
Author

should align now.
also is _reset_encoder() fine where it is?

@bedevere-app
Copy link

bedevere-app bot commented Jan 16, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

ZeroIntensity
ZeroIntensity reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a NEWS entry for this; error message changes are technically user-facing.

@bedevere-app
Copy link

bedevere-app bot commented Jan 16, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

ZeroIntensity
ZeroIntensity reviewed Jan 16, 2025
View reviewed changes
Misc/NEWS.d/next/Library/2025-01-15-23-51-44.gh-issue-128852.89wrex.rst Outdated
@@ -0,0 +1,2 @@
Align ``_pyio.TextIOWrapper.seek``'s file closed check with its C
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the technical details out of it. Could you say something about the error message?

@DimmaDont
Copy link
Author

how's this?

picnixz
picnixz reviewed Jan 17, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

+1 more reviewer

@lazysegtree lazysegtree lazysegtree approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review skip issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DimmaDont @picnixz @ZeroIntensity @lazysegtree @skirpichev